----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1128/#review2459 -----------------------------------------------------------
Where/when is this used? It seems kind of odd to add a new method and not add any use cases. I can see where support for cache-line-crossing accesses could use this, but only if that's done post-translation (otherwise splitOnVaddr() would be sufficient). Someone going back and trying to clean things up would be tempted to get rid of this as dead code. If there's a separate patch coming that actually uses this method, I'd prefer to see those patches merged. If not, something in the comment explaining when/where this is needed would be useful. src/mem/request.hh <http://reviews.gem5.org/r/1128/#comment2860> Seems like we should just use the default copy constructor here: req1 = new Request(*this); req2 = new Request(*this); Looks like you just copied splitOnVaddr(), so this issue should be fixed there too. - Steve Reinhardt On April 5, 2012, 12:22 p.m., Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1128/ > ----------------------------------------------------------- > > (Updated April 5, 2012, 12:22 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8930:1aab533823f3 > --------------------------- > request: added split Paddr function > > > Diffs > ----- > > src/mem/request.hh 570b44fe6e0430378a70155e9e265eeef9b031a2 > > Diff: http://reviews.gem5.org/r/1128/diff/ > > > Testing > ------- > > > Thanks, > > Brad Beckmann > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
