> On April 5, 2012, 12:47 p.m., Steve Reinhardt wrote: > > src/mem/request.hh, line 331 > > <http://reviews.gem5.org/r/1128/diff/2/?file=25575#file25575line331> > > > > Seems like we should just use the default copy constructor here: > > req1 = new Request(*this); > > req2 = new Request(*this); > > > > Looks like you just copied splitOnVaddr(), so this issue should be > > fixed there too.
And since you just copied splitOnVaddr, you should factor out all the common code into a new helper function and just specialize the little bits that are different. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1128/#review2459 ----------------------------------------------------------- On April 5, 2012, 12:22 p.m., Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1128/ > ----------------------------------------------------------- > > (Updated April 5, 2012, 12:22 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8930:1aab533823f3 > --------------------------- > request: added split Paddr function > > > Diffs > ----- > > src/mem/request.hh 570b44fe6e0430378a70155e9e265eeef9b031a2 > > Diff: http://reviews.gem5.org/r/1128/diff/ > > > Testing > ------- > > > Thanks, > > Brad Beckmann > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
