> On April 8, 2012, 8:10 a.m., Ali Saidi wrote: > > Seems fine overall, although I would think it would best be in src/base not > > src/sim. I second Andreas' comments about Doxygen. > >
I put it in src/sim since it was specifically targeted to address translation, but it's not entirely unreasonable to put it in base either if we turn the key type into a template parameter as Steve suggests. I think that may be somewhat superficial generalization because of the properties the key is assumed to have (an integer where & works, perhaps others). But it's not totally crazy so I'll just go ahead and do that. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1141/#review2507 ----------------------------------------------------------- On April 8, 2012, 1:02 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1141/ > ----------------------------------------------------------- > > (Updated April 8, 2012, 1:02 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8943:95056bc98bf5 > --------------------------- > sim: A trie data structure specifically to speed up paging lookups. > > This change adds a trie data structure which stores an arbitrary pointer type > based on an address and a number of relevant bits. Then lookups can be done > against the trie where the tree is traversed and the first legitimate match > found is retuned. > > > Diffs > ----- > > src/sim/addrtrie.hh PRE-CREATION > > Diff: http://reviews.gem5.org/r/1141/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
