> On April 8, 2012, 7:52 a.m., Andreas Hansson wrote: > > It looks good. The level of comments definitely needs a bump to make > > Doxygen happy.
Ok. I'll add some Doxygen style comments. > On April 8, 2012, 7:52 a.m., Andreas Hansson wrote: > > src/sim/addrtrie.hh, line 279 > > <http://reviews.gem5.org/r/1141/diff/1/?file=25679#file25679line279> > > > > const std::string& title? Nah. If I did that, it would construct and destruct an object which just wraps the parameter anyway. If I manipulated it that might be a good idea. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1141/#review2506 ----------------------------------------------------------- On April 8, 2012, 1:02 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1141/ > ----------------------------------------------------------- > > (Updated April 8, 2012, 1:02 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8943:95056bc98bf5 > --------------------------- > sim: A trie data structure specifically to speed up paging lookups. > > This change adds a trie data structure which stores an arbitrary pointer type > based on an address and a number of relevant bits. Then lookups can be done > against the trie where the tree is traversed and the first legitimate match > found is retuned. > > > Diffs > ----- > > src/sim/addrtrie.hh PRE-CREATION > > Diff: http://reviews.gem5.org/r/1141/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
