On Sun, Apr 29, 2012 at 1:18 AM, Gabe Black <[email protected]> wrote:
> > As far as the ioctl patch, I suspect the reason Vince Weaver wanted to > nuke the cases present in ioctlFunc is that the constants they rely on > don't exist in x86. They're defined for Alpha, MIPS, SPARC and powerpc, > and in the file that uses them in the kernel (drivers/tty/tty_ioctl.c) > conditionally compiles in the code that implements those calls based on > if the constant is defined. Attaching the ioctl functions breaks the > build because those constants aren't defined, and they aren't defined > because there's nothing to set them to. In these cases, I believe that just defining the constants using raw values is an acceptable and precedented thing to do. As you say, there aren't really any other options, and if it's a matter of binary compatibility with existing programs, the values are very unlikely to get changed anyway. Steve _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
