----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1189/#review2689 -----------------------------------------------------------
src/arch/x86/isa/insts/simd128/floating_point/arithmetic/horizontal_addition.py <http://reviews.gem5.org/r/1189/#comment3044> It would be better to put these loads earlier for two reasons. First, it helps hide their latency by allowing other things to run while they wait for their results. Second, it makes it easier to put the ufp-s in an order (say, ascending) so that it's easier to spot a typo. I'm glad to see this apparently worked, though. - Gabe Black On May 14, 2012, 6:27 p.m., Marc Orr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1189/ > ----------------------------------------------------------- > > (Updated May 14, 2012, 6:27 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8981:463aba906774 > --------------------------- > x86 ISA: Implement the sse3 haddps instruction. > > This patch is a revised version of Vince Weaver's patch from 592. > > > Diffs > ----- > > src/arch/x86/isa/decoder/two_byte_opcodes.isa > 4388495beb44ba859d20177371caf9e14902ef91 > > src/arch/x86/isa/insts/simd128/floating_point/arithmetic/horizontal_addition.py > 4388495beb44ba859d20177371caf9e14902ef91 > > Diff: http://reviews.gem5.org/r/1189/diff/ > > > Testing > ------- > > Wrote a little program that uses haddps. All 3 haddps versions were tested > (XMM_XMM, XMM_M, and XMM_P). > > > Thanks, > > Marc Orr > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
