I'm still not all that convinced that we need the full debug symbols here... but that's not a huge issue. My bigger complaint is that you pushed this changeset only 17 hours after posting the review request, and after only one "ship it!" review. That seems pretty rushed IMO.
Steve On Mon, May 28, 2012 at 12:51 AM, Gabe Black <[email protected]> wrote: > changeset 1f2568933bc5 in /z/repo/gem5 > details: http://repo.gem5.org/gem5?cmd=changeset;node=1f2568933bc5 > description: > X86: Add a 32 bit hello world test binary. > > diffstat: > > tests/test-progs/hello/bin/x86/linux/hello32 | 0 > 1 files changed, 0 insertions(+), 0 deletions(-) > > diffs (2 lines): > > diff -r 971f35a65a00 -r 1f2568933bc5 > tests/test-progs/hello/bin/x86/linux/hello32 > Binary file tests/test-progs/hello/bin/x86/linux/hello32 has changed > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
