The debug symbol thing is secondary... I'm not that concerned about that specific issue.
I certainly agree that the review process can be drawn out. We've discussed this before I know. I certainly sympathize with people that put reviews out there and don't get reviews back in a timely fashion (I do this to Andreas all the time), and I agree that you can't expect to get a yes vote out of everyone every time. I also know that we haven't established any hard rules about how long you should wait or how many votes you need to collect before committing. However I'm pretty sure I am not alone in thinking that waiting 17 hours on a holiday weekend and only collecting one yes vote is below the threshold. Steve On Mon, May 28, 2012 at 2:38 PM, Gabe Black <[email protected]> wrote: > Our review process moves slowly, and one yes vote is frequently all that > can be dragged out of reviewers in any time frame. Not having debug > symbols (which we have in everything else that's already checked in) in > something that has to be debugged frequently sounds pretty clearly like > a bad idea to me. > > Gabe > > On 05/28/12 07:56, Steve Reinhardt wrote: > > I'm still not all that convinced that we need the full debug symbols > > here... but that's not a huge issue. My bigger complaint is that you > > pushed this changeset only 17 hours after posting the review request, and > > after only one "ship it!" review. That seems pretty rushed IMO. > > > > Steve > > > > On Mon, May 28, 2012 at 12:51 AM, Gabe Black <[email protected]> > wrote: > > > >> changeset 1f2568933bc5 in /z/repo/gem5 > >> details: http://repo.gem5.org/gem5?cmd=changeset;node=1f2568933bc5 > >> description: > >> X86: Add a 32 bit hello world test binary. > >> > >> diffstat: > >> > >> tests/test-progs/hello/bin/x86/linux/hello32 | 0 > >> 1 files changed, 0 insertions(+), 0 deletions(-) > >> > >> diffs (2 lines): > >> > >> diff -r 971f35a65a00 -r 1f2568933bc5 > >> tests/test-progs/hello/bin/x86/linux/hello32 > >> Binary file tests/test-progs/hello/bin/x86/linux/hello32 has changed > >> _______________________________________________ > >> gem5-dev mailing list > >> [email protected] > >> http://m5sim.org/mailman/listinfo/gem5-dev > >> > > _______________________________________________ > > gem5-dev mailing list > > [email protected] > > http://m5sim.org/mailman/listinfo/gem5-dev > > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
