----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1241/#review2872 -----------------------------------------------------------
src/cpu/o3/dyn_inst.hh <http://reviews.gem5.org/r/1241/#comment3150> You probably want to put a comment here explaining that these are offsets from fetchTick and that's why they can be smaller. src/cpu/o3/dyn_inst.hh <http://reviews.gem5.org/r/1241/#comment3151> This may not be enough. In any case, an exact value could be calculated by the ISA parser like it does for total sources and dests. src/cpu/o3/rename_impl.hh <http://reviews.gem5.org/r/1241/#comment3152> Nothing for dests? That's odd, but not unbelievable. - Gabe Black On May 30, 2012, 3:13 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1241/ > ----------------------------------------------------------- > > (Updated May 30, 2012, 3:13 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9037:350f47d32f56 > --------------------------- > O3: Clean up the O3 structures and try to pack them a bit better. > > DynInst is extremely large the hope is that this re-organization will put the > most used members close to each other. > > > Diffs > ----- > > src/cpu/base_dyn_inst.hh 8b9f227b64d8 > src/cpu/base_dyn_inst_impl.hh 8b9f227b64d8 > src/cpu/o3/bpred_unit.hh 8b9f227b64d8 > src/cpu/o3/comm.hh 8b9f227b64d8 > src/cpu/o3/commit_impl.hh 8b9f227b64d8 > src/cpu/o3/decode_impl.hh 8b9f227b64d8 > src/cpu/o3/dyn_inst.hh 8b9f227b64d8 > src/cpu/o3/dyn_inst_impl.hh 8b9f227b64d8 > src/cpu/o3/iew_impl.hh 8b9f227b64d8 > src/cpu/o3/inst_queue_impl.hh 8b9f227b64d8 > src/cpu/o3/lsq_unit.hh 8b9f227b64d8 > src/cpu/o3/lsq_unit_impl.hh 8b9f227b64d8 > src/cpu/o3/rename_impl.hh 8b9f227b64d8 > > Diff: http://reviews.gem5.org/r/1241/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
