----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1243/#review2889 -----------------------------------------------------------
src/arch/x86/tlb.cc <http://reviews.gem5.org/r/1243/#comment3161> I see that altAddr and defAddr are defined by Gabe's bitfield package, which I assume makes them unsigned. Would it make more sense to change logSize to unsigned than to cast those fields to signed? - Steve Reinhardt On May 30, 2012, 9:57 p.m., Jayneel Gandhi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1243/ > ----------------------------------------------------------- > > (Updated May 30, 2012, 9:57 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9035:62ffaa5ca519 > --------------------------- > TLB: Fix for gcc 4.4.3 > Due to recent changes to TLB, gem5 stopped compiling on gcc version 4.4.3. > This > patch provides the fix for that problem. The patch is tested on gcc 4.4.3. The > change is not required for more recent versions of gcc (like on 4.6.3). > > > Diffs > ----- > > src/arch/x86/tlb.cc 8b9f227b64d8 > > Diff: http://reviews.gem5.org/r/1243/diff/ > > > Testing > ------- > > Compiles with gcc 4.4.3 > > > Thanks, > > Jayneel Gandhi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
