-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1243/#review2902
-----------------------------------------------------------
This line looks >80 chars; can you wrap it appropriately? Also, I'm fine with
using "unsigned" as an abbreviation for "unsigned int" (though that by itself
isn't enough to get you below 80 chars). So something like this:
unsigned logSize = sizeOverride ? (unsigned)m5Reg.altAddr
: (unsigned)m5Reg.defAddr;
- Steve Reinhardt
On June 4, 2012, 2:36 p.m., Jayneel Gandhi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1243/
> -----------------------------------------------------------
>
> (Updated June 4, 2012, 2:36 p.m.)
>
>
> Review request for Default.
>
>
> Description
> -------
>
> Changeset 9041:0589d3ba9809
> ---------------------------
> TLB: Fix for gcc 4.4.3
> Due to recent changes to TLB, gem5 stopped compiling on gcc version 4.4.3.
> This
> patch provides the fix for that problem. The patch is tested on gcc 4.4.3. The
> change is not required for more recent versions of gcc (like on 4.6.3).
>
>
> Diffs
> -----
>
> src/arch/x86/tlb.cc cdfe09f9bdee
>
> Diff: http://reviews.gem5.org/r/1243/diff/
>
>
> Testing
> -------
>
> Compiles with gcc 4.4.3
>
>
> Thanks,
>
> Jayneel Gandhi
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
