Any more thoughts on this patch? Thanks, Marc On Sun, May 20, 2012 at 8:52 PM, Marc Orr <[email protected]> wrote:
> This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1187/ > Review request for Default. > By Marc Orr. > > *Updated May 20, 2012, 8:52 p.m.* > Description (updated) > > Changeset 8979:c1ce40553d90 > --------------------------- > x86 syscall emulation: Add the TCGETS ioctl to the whitelist of tty ioctls > that > return -ENOTTY. > > This patch is a revised version of Vince Weaver's patch from 589. > > Testing > > Ran perlbench to confirm that that the workload is not held up by this ioctl. > Furthermore, ran all spec workloads as best I could to confirm that there are > no more ioctls called from them. Some of the inputs available to me were too > large to run all workloads to completion. Also, some of workloads fail due to > other causes. But I am fairly confident that this is the only ioctl that was > causing problems. > > Also, ran the regression tester to confirm that everything compiles. I still > need to examine the output a little more carefully to make sure everything > passes. > > Diffs (updated) > > - src/arch/alpha/linux/linux.hh > (4388495beb44ba859d20177371caf9e14902ef91) > - src/arch/alpha/tru64/tru64.hh > (4388495beb44ba859d20177371caf9e14902ef91) > - src/arch/arm/linux/linux.hh > (4388495beb44ba859d20177371caf9e14902ef91) > - src/arch/mips/linux/linux.hh > (4388495beb44ba859d20177371caf9e14902ef91) > - src/arch/power/linux/linux.hh > (4388495beb44ba859d20177371caf9e14902ef91) > - src/arch/x86/linux/linux.hh > (4388495beb44ba859d20177371caf9e14902ef91) > - src/arch/x86/linux/syscalls.cc > (4388495beb44ba859d20177371caf9e14902ef91) > - src/kern/linux/linux.hh (4388495beb44ba859d20177371caf9e14902ef91) > - src/sim/syscall_emul.hh (4388495beb44ba859d20177371caf9e14902ef91) > > View Diff <http://reviews.gem5.org/r/1187/diff/> > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
