----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1266/#review2940 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On June 11, 2012, 6:58 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1266/ > ----------------------------------------------------------- > > (Updated June 11, 2012, 6:58 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9074:542b2ace9778 > --------------------------- > Bus: Split the bus into separate request/response layers > > This patch splits the existing buses into multiple layers. The > non-coherent bus is split into a request and a response layer, and the > coherent bus adds an additional layer for the snoop responses. The > layer is modified to be templatised on the port type, such that the > different layers can have retryLists with either master or slave > ports. This patch also removes the dynamic cast from the retry, as > previously promised when moving the recvRetry from the port base class > to the master/slave port respectively. > > Overall, the split bus more closely reflects any modern on-chip bus > and should be at step in the right direction. From this point, it > would be reasonable straight forward to add separate layers (and thus > contention points and arbitration) for each port and thus create a > true crossbar. > > The regressions all produce the correct output, but have varying > degrees of changes to their statistics. A separate patch will be > pushed with the updates to the reference statistics. > > > Diffs > ----- > > src/mem/bus.hh 35ac3a6f8ee0 > src/mem/bus.cc 35ac3a6f8ee0 > src/mem/coherent_bus.hh 35ac3a6f8ee0 > src/mem/coherent_bus.cc 35ac3a6f8ee0 > src/mem/noncoherent_bus.hh 35ac3a6f8ee0 > src/mem/noncoherent_bus.cc 35ac3a6f8ee0 > > Diff: http://reviews.gem5.org/r/1266/diff/ > > > Testing > ------- > > util/regress all running and producing the right output (disregarding t1000 > and eio) but with essentially all timing tests exhibiting stat differences > reflecting less bus contention > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
