----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1283/#review3008 -----------------------------------------------------------
Looks good. Could you give it a quick run through valgrind to make sure there isn't any use after free issues between C++ and python? - Ali Saidi On July 2, 2012, 9:36 a.m., Andrew Lukefahr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1283/ > ----------------------------------------------------------- > > (Updated July 2, 2012, 9:36 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9086:a6172c62f094 > --------------------------- > fix some memory leaks in core switching > > > Diffs > ----- > > src/python/m5/simulate.py 5f0321c03a2602f34dd03700e41e0cf5b47b8761 > src/python/swig/pyevent.hh 5f0321c03a2602f34dd03700e41e0cf5b47b8761 > src/python/swig/pyevent.cc 5f0321c03a2602f34dd03700e41e0cf5b47b8761 > src/sim/simulate.cc 5f0321c03a2602f34dd03700e41e0cf5b47b8761 > > Diff: http://reviews.gem5.org/r/1283/diff/ > > > Testing > ------- > > > Thanks, > > Andrew Lukefahr > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
