> On Jan. 8, 2013, 6:25 a.m., Ali Saidi wrote: > > HI Andrew, > > > > Do you still believe this change is correct? It looks fine to me, but I've > > run into various kinds of memory corruption with the events as they get > > pasesd back between python and c++, so I would like to make sure that > > you're still using this code before we commit it. > > > > Thanks, > > Ali > >
I had this patch applied in my code, it never caused any problems. Granted, it was probably not tested extensively because the simulator would die for other reasons. I'll check it out with new changes and see if it's ok. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1283/#review3789 ----------------------------------------------------------- On July 2, 2012, 9:36 a.m., Andrew Lukefahr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1283/ > ----------------------------------------------------------- > > (Updated July 2, 2012, 9:36 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9086:a6172c62f094 > --------------------------- > fix some memory leaks in core switching > > > Diffs > ----- > > src/python/m5/simulate.py 5f0321c03a2602f34dd03700e41e0cf5b47b8761 > src/python/swig/pyevent.hh 5f0321c03a2602f34dd03700e41e0cf5b47b8761 > src/python/swig/pyevent.cc 5f0321c03a2602f34dd03700e41e0cf5b47b8761 > src/sim/simulate.cc 5f0321c03a2602f34dd03700e41e0cf5b47b8761 > > Diff: http://reviews.gem5.org/r/1283/diff/ > > > Testing > ------- > > > Thanks, > > Andrew Lukefahr > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
