----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1298/#review3061 -----------------------------------------------------------
I'm fine with getting rid of the cast operator, but how about we just rename the queue accessor to something less ambiguous like eventQueue()? When we go to multiple event queues it probably will be handy to know which queue you're on at times. I only use queue() once in my patch (http://reviews.gem5.org/r/846), and even there I'm not sure why that particular change is relevant, but still it would be nice not to lose the method entirely. - Steve Reinhardt On July 6, 2012, 6:40 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1298/ > ----------------------------------------------------------- > > (Updated July 6, 2012, 6:40 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9104:a3655fd63449 > --------------------------- > EventManager: Remove the queue member function and operator > > This patch removes the queue() member function and cast operator as > they are never used outside the EventManager. The queue() member > function cause problems in derived classes that declare members with > the same name, e.g. a MemObject subclass that has a packet queue on > its own. The operator is not causing any harm at this point, but as it > is not used there is little point in keeping it. > > > Diffs > ----- > > src/sim/eventq.hh 5f0321c03a26 > > Diff: http://reviews.gem5.org/r/1298/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
