----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1298/#review3064 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On July 6, 2012, 7:56 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1298/ > ----------------------------------------------------------- > > (Updated July 6, 2012, 7:56 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9104:0f9b39cb455d > --------------------------- > EventManager: Rename queue accessor and remove cast operator > > This patch renames the queue() accessor to the less ambigious > eventQueue, and also removes the cast operator. The queue() member > function cause problems in derived classes that declare members with > the same name, e.g. a MemObject subclass that has a packet queue on > its own. The operator is not causing any harm at this point, but as it > is not used there is little point in keeping it. > > > Diffs > ----- > > src/sim/eventq.hh 5f0321c03a26 > > Diff: http://reviews.gem5.org/r/1298/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
