Hey Brad,
Sorry for the delayed response on this. I've played around with Valgrind
suppressions recently, but I had unfortunately just cleaned house so I
didn't have any Valgrind output files that I could look at to validate that
these updates are necessary. I just finished collecting a couple new
Valgrind runs, and I don't see any STL memory errors, so I don't think this
patch was necessary with the current gem5.
Joel
On Wed, Jul 11, 2012 at 11:34 AM, Brad Beckmann <[email protected]>wrote:
>
>
> > On July 8, 2012, 10:16 a.m., Ali Saidi wrote:
> > > There is something in teh STL that valgrind thinks is an error?
> > >
> > >
>
> I don't know for sure. This is a patch developed by Joel Hestness a
> couple years ago that has been sitting around in our patch queue. Since
> Joel didn't respond, I decided to just drop the patch.
>
>
> - Brad
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1289/#review3070
> -----------------------------------------------------------
>
>
> On July 2, 2012, 10:43 p.m., Brad Beckmann wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviews.gem5.org/r/1289/
> > -----------------------------------------------------------
> >
> > (Updated July 2, 2012, 10:43 p.m.)
> >
> >
> > Review request for Default.
> >
> >
> > Description
> > -------
> >
> > Changeset 9077:504d8cfa6ff3
> > ---------------------------
> > Valgrind Suppressions: update to support common STL optimizations
> >
> >
> > Diffs
> > -----
> >
> > util/valgrind-suppressions d8e5ca139d7c24eeb665ac0aab41e180886278cb
> >
> > Diff: http://reviews.gem5.org/r/1289/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Brad Beckmann
> >
> >
>
> _______________________________________________
> gem5-dev mailing list
> [email protected]
> http://m5sim.org/mailman/listinfo/gem5-dev
>
--
Joel Hestness
PhD Student, Computer Architecture
Dept. of Computer Science, University of Wisconsin - Madison
Dept. of Computer Science, University of Texas - Austin
http://www.cs.utexas.edu/~hestness
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
