----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1315/ -----------------------------------------------------------
Review request for Default. Description ------- Changeset 9132:38e070ab0dfd --------------------------- Packet: Remove NACKs from packet and its use in endpoints This patch removes the NACK frrom the packet as there is no longer any module in the system that issues them (the bridge was the only one and the previous patch removes that). The handling of NACKs was mostly avoided throughout the code base, by using e.g. panic or assert false, but in a few locations the NACKs were actually dealt with (although NACKs never occured in any of the regressions). Most notably, the DMA port will now never receive a NACK and this affects how the backoff time is modified. Currently, the code is commented out, but should be re-enabled and respond to the successful sending (rather than responses as it used to be). A follow-up patch will address this and also make a number of changes to the DMA ports. Surprisingly, this patch has no impact on any of the regressions. As mentioned in the patch that removes the NACK from the bridge, a follow-up patch should change the request and response buffer size for at least one regression to also veryfy that the system behaves as expected when the bridge fills up. Diffs ----- src/arch/x86/pagetable_walker.cc 2f6f0631af48 src/cpu/o3/fetch_impl.hh 2f6f0631af48 src/cpu/o3/lsq_unit_impl.hh 2f6f0631af48 src/cpu/simple/timing.cc 2f6f0631af48 src/dev/dma_device.cc 2f6f0631af48 src/mem/cache/cache_impl.hh 2f6f0631af48 src/mem/packet.hh 2f6f0631af48 src/mem/packet.cc 2f6f0631af48 Diff: http://reviews.gem5.org/r/1315/diff/ Testing ------- util/regress all passing (disregarding t1000 and eio) Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
