> On July 22, 2012, 7:19 p.m., Steve Reinhardt wrote: > > configs/common/Simulation.py, line 167 > > <http://reviews.gem5.org/r/1311/diff/2/?file=27986#file27986line167> > > > > It looks like some of this added code duplicates code above... can we > > get away with reusing the switch_cpus list instead of creating a new > > repeat_switch_cpus list?
I did this because I wanted to make it easy for people use this functionality with --fast-forward however, I didn't add in --fast-forward support with --repeat-switch. It's there now. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1311/#review3128 ----------------------------------------------------------- On July 23, 2012, 5:39 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1311/ > ----------------------------------------------------------- > > (Updated July 23, 2012, 5:39 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9130:75db2cd47361 > --------------------------- > configs: add option for repeatedly switching back-and-forth between cpu types. > > This patch adds a --repeat-switch option that will enable repeat core > switching at a user defined period (set with --switch-freq option). > currently, a switch can only occur between like CPU types. inorder CPU > switching is not supported. > > *note* > this patch simply allows a config that will perform repeat switching, it > does not fix drain/switchout functionality. if you run with repeat switching > you will hit assertion failures and/or your workload with hang or die. > > > Diffs > ----- > > configs/common/Options.py b57966a6c51249cf17fb9633a00d055fc260d72b > configs/common/Simulation.py b57966a6c51249cf17fb9633a00d055fc260d72b > > Diff: http://reviews.gem5.org/r/1311/diff/ > > > Testing > ------- > > The options added to this config play nicely with the other options. > Ran with repeat switching on with various other options. Simulation > started and ran successfully while switching until an assertion failed > or the workload kernel panicked or hung due to drain/switchout bugs. > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
