----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1306/#review3223 -----------------------------------------------------------
Looks fine to me. I am guessing you already tested that all the protocols in the repo compile without any problems. SConstruct <http://reviews.gem5.org/r/1306/#comment3350> This is probably longer than 80 characters. src/mem/protocol/SConscript <http://reviews.gem5.org/r/1306/#comment3351> Why do we need this change? - Nilay Vaish On July 19, 2012, 9:46 a.m., Jason Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1306/ > ----------------------------------------------------------- > > (Updated July 19, 2012, 9:46 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9121:1653229eceb3 > --------------------------- > Ruby: Modify Scons so that we can put .sm files in extras > > Also allows for header files which are required in slicc generated > code to be in a directory other than src/mem/ruby/slicc_interface. > > > Diffs > ----- > > SConstruct 48eeef8a0997 > src/mem/protocol/SConscript 48eeef8a0997 > src/mem/protocol/SConsopts 48eeef8a0997 > src/mem/slicc/parser.py 48eeef8a0997 > src/mem/slicc/symbols/Func.py 48eeef8a0997 > src/mem/slicc/symbols/StateMachine.py 48eeef8a0997 > src/mem/slicc/symbols/SymbolTable.py 48eeef8a0997 > src/mem/slicc/symbols/Type.py 48eeef8a0997 > src/mem/slicc/symbols/Var.py 48eeef8a0997 > > Diff: http://reviews.gem5.org/r/1306/diff/ > > > Testing > ------- > > > Thanks, > > Jason Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
