> On Aug. 26, 2012, 5:59 p.m., Andreas Hansson wrote: > > src/mem/protocol/SConscript, line 93 > > <http://reviews.gem5.org/r/1306/diff/3/?file=28806#file28806line93> > > > > Do we support multiple protocols? Why the iteration?
No, we don't support multiple protocols. What I'm trying to enable here is supporting multiple directories for the protocol to live in. This way I can have protocol files in gem5/../<my extras dir>/protocols for example. > On Aug. 26, 2012, 5:59 p.m., Andreas Hansson wrote: > > src/mem/slicc/symbols/StateMachine.py, line 440 > > <http://reviews.gem5.org/r/1306/diff/3/?file=28810#file28810line440> > > > > Opening namespace in a header? Should do so if that is the case. This isn't a header, it's the C file (since this is in fucntion printControllerCC). Just to double check, "grep using build/X86_MESI_CMP_directory/mem/protocol/*.hh" doesn't result in any hits. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1306/#review3344 ----------------------------------------------------------- On Aug. 14, 2012, 8:20 a.m., Jason Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1306/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2012, 8:20 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9121:1653229eceb3 > --------------------------- > Ruby: Modify Scons so that we can put .sm files in extras > > Also allows for header files which are required in slicc generated > code to be in a directory other than src/mem/ruby/slicc_interface. > > > Diffs > ----- > > SConstruct b4d0bdb52694 > src/mem/protocol/SConscript b4d0bdb52694 > src/mem/protocol/SConsopts b4d0bdb52694 > src/mem/slicc/parser.py b4d0bdb52694 > src/mem/slicc/symbols/Func.py b4d0bdb52694 > src/mem/slicc/symbols/StateMachine.py b4d0bdb52694 > src/mem/slicc/symbols/SymbolTable.py b4d0bdb52694 > src/mem/slicc/symbols/Type.py b4d0bdb52694 > src/mem/slicc/symbols/Var.py b4d0bdb52694 > > Diff: http://reviews.gem5.org/r/1306/diff/ > > > Testing > ------- > > > Thanks, > > Jason Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
