changeset e353c178fb36 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=e353c178fb36
description:
CPU: Remove overloaded function_trace_start parameter
This patch removes the overloading of the parameter, which seems both
redundant, and possibly incorrect.
The inorder CPU is particularly interesting as it uses a different
name for the parameter, and never make any use of it internally.
diffstat:
src/cpu/BaseCPU.py | 2 +-
src/cpu/CheckerCPU.py | 2 --
src/cpu/inorder/InOrderCPU.py | 3 +--
src/cpu/o3/O3Checker.py | 2 --
src/cpu/ozone/OzoneCPU.py | 3 ---
src/cpu/ozone/OzoneChecker.py | 2 --
src/cpu/ozone/SimpleOzoneCPU.py | 3 ---
7 files changed, 2 insertions(+), 15 deletions(-)
diffs (75 lines):
diff -r 584662eaaecf -r e353c178fb36 src/cpu/BaseCPU.py
--- a/src/cpu/BaseCPU.py Tue Aug 21 05:49:24 2012 -0400
+++ b/src/cpu/BaseCPU.py Tue Aug 21 05:49:43 2012 -0400
@@ -82,7 +82,7 @@
numThreads = Param.Unsigned(1, "number of HW thread contexts")
function_trace = Param.Bool(False, "Enable function trace")
- function_trace_start = Param.Tick(0, "Cycle to start function trace")
+ function_trace_start = Param.Tick(0, "Tick to start function trace")
checker = Param.BaseCPU(NULL, "checker CPU")
diff -r 584662eaaecf -r e353c178fb36 src/cpu/CheckerCPU.py
--- a/src/cpu/CheckerCPU.py Tue Aug 21 05:49:24 2012 -0400
+++ b/src/cpu/CheckerCPU.py Tue Aug 21 05:49:43 2012 -0400
@@ -37,5 +37,3 @@
"Update the checker with the main CPU's state on an error")
warnOnlyOnLoadError = Param.Bool(True,
"If a load result is incorrect, only print a warning and do not exit")
- function_trace = Param.Bool(False, "Enable function trace")
- function_trace_start = Param.Tick(0, "Cycle to start function trace")
diff -r 584662eaaecf -r e353c178fb36 src/cpu/inorder/InOrderCPU.py
--- a/src/cpu/inorder/InOrderCPU.py Tue Aug 21 05:49:24 2012 -0400
+++ b/src/cpu/inorder/InOrderCPU.py Tue Aug 21 05:49:43 2012 -0400
@@ -62,8 +62,7 @@
RASSize = Param.Unsigned(16, "RAS size")
instShiftAmt = Param.Unsigned(2, "Number of bits to shift instructions by")
- functionTrace = Param.Bool(False, "Enable function trace")
- functionTraceStart = Param.Tick(0, "Cycle to start function trace")
+
stageTracing = Param.Bool(False, "Enable tracing of each stage in CPU")
multLatency = Param.Unsigned(1, "Latency for Multiply Operations")
diff -r 584662eaaecf -r e353c178fb36 src/cpu/o3/O3Checker.py
--- a/src/cpu/o3/O3Checker.py Tue Aug 21 05:49:24 2012 -0400
+++ b/src/cpu/o3/O3Checker.py Tue Aug 21 05:49:43 2012 -0400
@@ -36,5 +36,3 @@
"Update the checker with the main CPU's state on an error")
warnOnlyOnLoadError = Param.Bool(True,
"If a load result is incorrect, only print a warning and do not exit")
- function_trace = Param.Bool(False, "Enable function trace")
- function_trace_start = Param.Tick(0, "Cycle to start function trace")
diff -r 584662eaaecf -r e353c178fb36 src/cpu/ozone/OzoneCPU.py
--- a/src/cpu/ozone/OzoneCPU.py Tue Aug 21 05:49:24 2012 -0400
+++ b/src/cpu/ozone/OzoneCPU.py Tue Aug 21 05:49:43 2012 -0400
@@ -113,9 +113,6 @@
instShiftAmt = Param.Unsigned("Number of bits to shift instructions by")
- function_trace = Param.Bool(False, "Enable function trace")
- function_trace_start = Param.Tick(0, "Cycle to start function trace")
-
# If the CheckerCPU is brought back to useability in the OzoneCPU, create a
# function here called addCheckerCpu() to create a non-NULL Checker and
# connect its TLBs (if needed)
diff -r 584662eaaecf -r e353c178fb36 src/cpu/ozone/OzoneChecker.py
--- a/src/cpu/ozone/OzoneChecker.py Tue Aug 21 05:49:24 2012 -0400
+++ b/src/cpu/ozone/OzoneChecker.py Tue Aug 21 05:49:43 2012 -0400
@@ -36,5 +36,3 @@
"Update the checker with the main CPU's state on an error")
warnOnlyOnLoadError = Param.Bool(False,
"If a load result is incorrect, only print a warning and do not exit")
- function_trace = Param.Bool(False, "Enable function trace")
- function_trace_start = Param.Tick(0, "Cycle to start function trace")
diff -r 584662eaaecf -r e353c178fb36 src/cpu/ozone/SimpleOzoneCPU.py
--- a/src/cpu/ozone/SimpleOzoneCPU.py Tue Aug 21 05:49:24 2012 -0400
+++ b/src/cpu/ozone/SimpleOzoneCPU.py Tue Aug 21 05:49:43 2012 -0400
@@ -109,6 +109,3 @@
numROBEntries = Param.Unsigned("Number of reorder buffer entries")
instShiftAmt = Param.Unsigned("Number of bits to shift instructions by")
-
- function_trace = Param.Bool(False, "Enable function trace")
- function_trace_start = Param.Tick(0, "Cycle to start function trace")
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
