----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1362/#review3283 -----------------------------------------------------------
src/mem/ruby/system/MemoryControl.py <http://reviews.gem5.org/r/1362/#comment3383> How about changing SimObject to ClockedObject? Then, you would not need to add a new param clock in RubyMemoryControl.py. You would need to set it though. You would be able to make use of certain functions that ClockedObject class provides. src/mem/ruby/system/RubyMemoryControl.cc <http://reviews.gem5.org/r/1362/#comment3382> Joel, this is another line where schedule() is called. You might want to check if it needs to be fixed as well. - Nilay Vaish On Aug. 21, 2012, 3:22 p.m., Joel Hestness wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1362/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2012, 3:22 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9156:0cdcf94f243f > --------------------------- > Ruby Memory Controller: Fix clocking > > Changeset 8937 switched the Ruby memory controller over to using the gem5 > event queue instead of the Ruby event queue, but it did not correctly > implement the clocking of the memory controller. This patch fixes that > functionality by changing the memory controller over to traditional gem5 > frequency specification. > > > Diffs > ----- > > src/mem/ruby/system/MemoryControl.py 4c67c26fa76e > src/mem/ruby/system/RubyMemoryControl.hh 4c67c26fa76e > src/mem/ruby/system/RubyMemoryControl.cc 4c67c26fa76e > src/mem/ruby/system/RubyMemoryControl.py 4c67c26fa76e > > Diff: http://reviews.gem5.org/r/1362/diff/ > > > Testing > ------- > > > Thanks, > > Joel Hestness > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
