> On Aug. 21, 2012, 3:51 p.m., Nilay Vaish wrote: > > src/mem/ruby/system/MemoryControl.py, line 33 > > <http://reviews.gem5.org/r/1362/diff/1/?file=28938#file28938line33> > > > > How about changing SimObject to ClockedObject? Then, you would not need > > to > > add a new param clock in RubyMemoryControl.py. You would need to set it > > though. > > You would be able to make use of certain functions that ClockedObject > > class provides.
Will make this change and resubmit. > On Aug. 21, 2012, 3:51 p.m., Nilay Vaish wrote: > > src/mem/ruby/system/RubyMemoryControl.cc, line 312 > > <http://reviews.gem5.org/r/1362/diff/1/?file=28940#file28940line312> > > > > Joel, this is another line where schedule() is called. You might want > > to check if it needs to be fixed as well. Yep, I checked this one out. This schedule call is only used when the memory controller is being woken up from idle by an enqueue call from the directory (i.e. when the cycle event isn't currently scheduled). Scheduling the wakeup 1 tick after the request arrives seems reasonable. Separate from this patch, I had also instrumented the code to collect the number of cycles that the memory controller executes for verification purposes. In a handful of tests, the number of ticks was the appropriate frequency multiple of the number of cycles. - Joel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1362/#review3283 ----------------------------------------------------------- On Aug. 21, 2012, 3:22 p.m., Joel Hestness wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1362/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2012, 3:22 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9156:0cdcf94f243f > --------------------------- > Ruby Memory Controller: Fix clocking > > Changeset 8937 switched the Ruby memory controller over to using the gem5 > event queue instead of the Ruby event queue, but it did not correctly > implement the clocking of the memory controller. This patch fixes that > functionality by changing the memory controller over to traditional gem5 > frequency specification. > > > Diffs > ----- > > src/mem/ruby/system/MemoryControl.py 4c67c26fa76e > src/mem/ruby/system/RubyMemoryControl.hh 4c67c26fa76e > src/mem/ruby/system/RubyMemoryControl.cc 4c67c26fa76e > src/mem/ruby/system/RubyMemoryControl.py 4c67c26fa76e > > Diff: http://reviews.gem5.org/r/1362/diff/ > > > Testing > ------- > > > Thanks, > > Joel Hestness > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
