> On Aug. 25, 2012, 2:07 a.m., Andreas Hansson wrote: > > Any comments on the testing? Looks good overall.
It passes the quick regression tests, at least. I don't think any of them actually catch the previous bug either, but as far as I can tell it didn't break anything new. - Lena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1294/#review3319 ----------------------------------------------------------- On Aug. 24, 2012, 7:31 p.m., Lena Olson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1294/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2012, 7:31 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9167:1bd0c85445a2 > --------------------------- > Cache: Split invalidateBlk up to seperate block vs. tags > > This seperates the functionality to clear the state in a block into blk.hh and > the functionality to udpate the tag information into the tags. This gets rid > of > the case where calling invalidateBlk on an already-invalid block does > something > different than calling it on a valid block, which was confusing. > > > Diffs > ----- > > src/mem/cache/blk.hh 1d983855df2c941655cda665056c6b3a8bd3d463 > src/mem/cache/cache_impl.hh 1d983855df2c941655cda665056c6b3a8bd3d463 > src/mem/cache/tags/fa_lru.hh 1d983855df2c941655cda665056c6b3a8bd3d463 > src/mem/cache/tags/fa_lru.cc 1d983855df2c941655cda665056c6b3a8bd3d463 > src/mem/cache/tags/iic.hh 1d983855df2c941655cda665056c6b3a8bd3d463 > src/mem/cache/tags/iic.cc 1d983855df2c941655cda665056c6b3a8bd3d463 > src/mem/cache/tags/lru.hh 1d983855df2c941655cda665056c6b3a8bd3d463 > src/mem/cache/tags/lru.cc 1d983855df2c941655cda665056c6b3a8bd3d463 > > Diff: http://reviews.gem5.org/r/1294/diff/ > > > Testing > ------- > > > Thanks, > > Lena Olson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
