----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1294/#review3364 -----------------------------------------------------------
src/mem/cache/cache_impl.hh <http://reviews.gem5.org/r/1294/#comment3447> Added extra white space at the end src/mem/cache/tags/lru.cc <http://reviews.gem5.org/r/1294/#comment3448> I think Steve mentioned something about combining these. E.g.: assert(blk && blk->isValid()); - Anthony Gutierrez On Aug. 30, 2012, 9:37 a.m., Lena Olson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1294/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2012, 9:37 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9182:c9ca95595667 > --------------------------- > Cache: Split invalidateBlk up to seperate block vs. tags > > This seperates the functionality to clear the state in a block into blk.hh and > the functionality to udpate the tag information into the tags. This gets rid > of > the case where calling invalidateBlk on an already-invalid block does > something > different than calling it on a valid block, which was confusing. > > > Diffs > ----- > > src/mem/cache/blk.hh 42807286d6cb > src/mem/cache/cache_impl.hh 42807286d6cb > src/mem/cache/tags/fa_lru.hh 42807286d6cb > src/mem/cache/tags/fa_lru.cc 42807286d6cb > src/mem/cache/tags/iic.hh 42807286d6cb > src/mem/cache/tags/iic.cc 42807286d6cb > src/mem/cache/tags/lru.hh 42807286d6cb > src/mem/cache/tags/lru.cc 42807286d6cb > > Diff: http://reviews.gem5.org/r/1294/diff/ > > > Testing > ------- > > > Thanks, > > Lena Olson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
