----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1373/#review3335 -----------------------------------------------------------
Looking at this code reminds me that we should standardize this code on uint32_t, uint64_t, etc. That should be a separate patch though. src/mem/ruby/system/MemoryVector.hh <http://reviews.gem5.org/r/1373/#comment3433> Should this be 64 bits too? - Steve Reinhardt On Aug. 25, 2012, 1:57 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1373/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2012, 1:57 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9170:84d304d618ed > --------------------------- > Ruby Memory Vector: Allow more than 4GB of memory > The memory size variable was a 32-bit int. This meant that the size of the > memory was limited to 4GB. This patch changes the type of the variable to > 64-bit to support larger memory sizes. Thanks to Raghuraman Balasubramanian > for bringing this to notice. > > > Diffs > ----- > > src/mem/ruby/system/MemoryVector.hh 89acf0b76858 > > Diff: http://reviews.gem5.org/r/1373/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
