----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1402/#review3410 -----------------------------------------------------------
src/arch/arm/table_walker.cc <http://reviews.gem5.org/r/1402/#comment3471> gat => got src/arch/arm/table_walker.cc <http://reviews.gem5.org/r/1402/#comment3473> Is this to remember the current tc for the walk after squashing? src/arch/arm/table_walker.cc <http://reviews.gem5.org/r/1402/#comment3472> Is not really needed as this is the "else" block, but I'm happy to keep it here. src/cpu/simple/timing.hh <http://reviews.gem5.org/r/1402/#comment3475> const? src/cpu/translation.hh <http://reviews.gem5.org/r/1402/#comment3474> bool isSquashed() const? src/sim/tlb.hh <http://reviews.gem5.org/r/1402/#comment3476> const? Who ever returns true? isSquashed to be consistent in the naming? - Andreas Hansson On Sept. 7, 2012, 12:52 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1402/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2012, 12:52 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9206:434a3ad49be9 > --------------------------- > ARM: Squash outstanding walks when instructions are squashed. > > > Diffs > ----- > > src/arch/arm/ArmTLB.py 87967784f101 > src/arch/arm/table_walker.hh 87967784f101 > src/arch/arm/table_walker.cc 87967784f101 > src/cpu/simple/timing.hh 87967784f101 > src/cpu/translation.hh 87967784f101 > src/sim/tlb.hh 87967784f101 > > Diff: http://reviews.gem5.org/r/1402/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
