This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1366/
configs/ruby/MOESI_hammer.py<http://reviews.gem5.org/r/1366/diff/1/?file=28978#file28978line152>
(Diff revision 1)
def create_system(options, system, piobus, dma_ports, ruby_system):
152
assert(options.numa_high_bit - dir_bits > pf_bits)
152
assert(options.numa_high_bit - dir_bits > pf_bits)
All of this probe filter setup should be predicated on whether the
probe filter is actually enabled (options.pf_on = True). If the probe
filter is NOT enabled, then it should be possible to set
options.numa_high_bit within the pf_bits range (not currently possible
because of this assertion). Trying to fix up the pf_start_bit without
first checking whether the probe filter is enabled will probably cause
redundant changes down the road.
Is anyone actually using the probe filter?
configs/ruby/Ruby.py<http://reviews.gem5.org/r/1366/diff/1/?file=28979#file28979line182>
(Diff revision 1)
class RouterClass(BasicRouter): pass
181
if dir_bits > 0:
182
if dir_bits > 0:
Is this distinction necessary? When the number of directory bits is 0,
the DirectoryMemory doesn't use the numa_high_bit
(mapAddressToDirectoryVersion and mapAddressToLocalIdx). Eliminating
this if-statement and just setting numa_bit = block_size_bits +
dir_bits - 1 would simplify the code and make it easier to debug
directory mapping mods.
- Joel
On Wed, Aug 22, 2012 at 2:15 PM, Jason Power <[email protected]> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1366/
> -----------------------------------------------------------
>
> Review request for Default.
>
>
> Description
> -------
>
> Changeset 9167:2bac206316cc
> ---------------------------
> Ruby: Fix hard-coded block size assumption for multiple directories
>
>
> Diffs
> -----
>
> configs/ruby/MOESI_hammer.py 019047ead23b
> configs/ruby/Ruby.py 019047ead23b
>
> Diff: http://reviews.gem5.org/r/1366/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Power
>
> _______________________________________________
> gem5-dev mailing list
> [email protected]
> http://m5sim.org/mailman/listinfo/gem5-dev
>
--
Joel Hestness
PhD Student, Computer Architecture
Dept. of Computer Science, University of Wisconsin - Madison
http://www.cs.utexas.edu/~hestness
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
