> On Sept. 10, 2012, 7:58 p.m., Joel Hestness wrote: > > configs/ruby/MOESI_hammer.py, line 152 > > <http://reviews.gem5.org/r/1366/diff/1/?file=28978#file28978line152> > > > > All of this probe filter setup should be predicated on whether the > > probe filter is actually enabled (options.pf_on = True). If the probe > > filter is NOT enabled, then it should be possible to set > > options.numa_high_bit within the pf_bits range (not currently possible > > because of this assertion). Trying to fix up the pf_start_bit without first > > checking whether the probe filter is enabled will probably cause redundant > > changes down the road. > > > > Is anyone actually using the probe filter?
I still use it and I suspect others find it useful as well. Sure we can wrap the current set of computation under the assumption of whether the probe filter or full-bit directoy is enabled. > On Sept. 10, 2012, 7:58 p.m., Joel Hestness wrote: > > configs/ruby/Ruby.py, line 182 > > <http://reviews.gem5.org/r/1366/diff/1/?file=28979#file28979line182> > > > > Is this distinction necessary? When the number of directory bits is 0, > > the DirectoryMemory doesn't use the numa_high_bit > > (mapAddressToDirectoryVersion and mapAddressToLocalIdx). Eliminating this > > if-statement and just setting numa_bit = block_size_bits + dir_bits - 1 > > would simplify the code and make it easier to debug directory mapping mods. We could do that, but it seems awkward to set the numa_bit to be within the block offset when the number of directories is 1. Actually, I think there may be an assertion somewhere else in the code that checks against that. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1366/#review3436 ----------------------------------------------------------- On Aug. 22, 2012, 12:15 p.m., Jason Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1366/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2012, 12:15 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9167:2bac206316cc > --------------------------- > Ruby: Fix hard-coded block size assumption for multiple directories > > > Diffs > ----- > > configs/ruby/MOESI_hammer.py 019047ead23b > configs/ruby/Ruby.py 019047ead23b > > Diff: http://reviews.gem5.org/r/1366/diff/ > > > Testing > ------- > > > Thanks, > > Jason Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
