----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1443/#review3520 -----------------------------------------------------------
Seems fine to me. Anything on the testing? - Andreas Hansson On Sept. 24, 2012, 6:15 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1443/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2012, 6:15 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9257:5bd46130593a > --------------------------- > ruby: augment network to support functional accesses > This patch adds support to ruby's network subsystem to support functional > accesses. This support exists for the simple network as of now. Later on > Garnet will also support functional accesses. > The patch adds functional access code to all the different types of messages > that protocols can send around. These messages are functionally accessed > by going through the buffers maintained by the network entities. In case of > the simple network, this entity is the Switch structure. > > > Diffs > ----- > > src/mem/protocol/MESI_CMP_directory-dir.sm 73c3eb0dd733 > src/mem/protocol/MESI_CMP_directory-msg.sm 73c3eb0dd733 > src/mem/protocol/MI_example-msg.sm 73c3eb0dd733 > src/mem/protocol/MOESI_CMP_directory-L2cache.sm 73c3eb0dd733 > src/mem/protocol/MOESI_CMP_directory-msg.sm 73c3eb0dd733 > src/mem/protocol/MOESI_CMP_token-L1cache.sm 73c3eb0dd733 > src/mem/protocol/MOESI_CMP_token-msg.sm 73c3eb0dd733 > src/mem/protocol/MOESI_hammer-msg.sm 73c3eb0dd733 > src/mem/protocol/Network_test-msg.sm 73c3eb0dd733 > src/mem/protocol/RubySlicc_Exports.sm 73c3eb0dd733 > src/mem/protocol/RubySlicc_MemControl.sm 73c3eb0dd733 > src/mem/protocol/RubySlicc_Util.sm 73c3eb0dd733 > src/mem/ruby/buffers/MessageBuffer.hh 73c3eb0dd733 > src/mem/ruby/buffers/MessageBuffer.cc 73c3eb0dd733 > src/mem/ruby/buffers/MessageBufferNode.hh 73c3eb0dd733 > src/mem/ruby/network/Network.hh 73c3eb0dd733 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh 73c3eb0dd733 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 73c3eb0dd733 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh 73c3eb0dd733 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 73c3eb0dd733 > src/mem/ruby/network/simple/PerfectSwitch.cc 73c3eb0dd733 > src/mem/ruby/network/simple/SimpleNetwork.hh 73c3eb0dd733 > src/mem/ruby/network/simple/SimpleNetwork.cc 73c3eb0dd733 > src/mem/ruby/network/simple/Switch.hh 73c3eb0dd733 > src/mem/ruby/network/simple/Switch.cc 73c3eb0dd733 > src/mem/ruby/slicc_interface/AbstractController.hh 73c3eb0dd733 > src/mem/ruby/slicc_interface/Message.hh 73c3eb0dd733 > src/mem/ruby/slicc_interface/NetworkMessage.hh 73c3eb0dd733 > src/mem/ruby/slicc_interface/RubyRequest.hh 73c3eb0dd733 > src/mem/ruby/slicc_interface/RubyRequest.cc 73c3eb0dd733 > src/mem/ruby/slicc_interface/RubySlicc_Util.hh 73c3eb0dd733 > src/mem/ruby/system/System.cc 73c3eb0dd733 > src/mem/slicc/ast/TypeDeclAST.py 73c3eb0dd733 > src/mem/slicc/symbols/StateMachine.py 73c3eb0dd733 > src/mem/slicc/symbols/SymbolTable.py 73c3eb0dd733 > src/mem/slicc/symbols/Type.py 73c3eb0dd733 > > Diff: http://reviews.gem5.org/r/1443/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
