It uses "goto". In my world that qualifies as broken :-) Kidding aside, I wouldn't know how to test it. If someone wants that functionality in the future I'd suggest they re-add it or resurrect it from the repo.
Makes sense? Andreas On 25/11/2012 18:27, "nathan binkert" <[email protected]> wrote: >As for deleting it, is it broken? > >On Tue, Nov 20, 2012 at 5:35 AM, Andreas Hansson ><[email protected]> wrote: >> I assume from the silence that it can go. I'll proceed and post a patch >> removing it. >> >> Andreas >> >> >> On 15/11/2012 13:57, "Andreas Hansson" <[email protected]> wrote: >> >>>Hi everyone, >>> >>>In the ns_gige code there are a few blocks surrounded by "if (clock)" >>>statements that all seem to be related to the tx/rx kick generation and >>>handling. By default the clock is set to 0 and the tx/rx kick is >>>disabled. I'd like to firm up the checks on the clock and add a check to >>>ensure it is not zero. Therefore, I'd like to either remove the code >>>entirely, or get it in such a shape that the clock is used properly. >>> >>>Any suggestions or ideas? >>> >>>Thanks, >>> >>>Andreas >>> >>> >>>-- IMPORTANT NOTICE: The contents of this email and any attachments are >>>confidential and may also be privileged. If you are not the intended >>>recipient, please notify the sender immediately and do not disclose the >>>contents to any other person, use it for any purpose, or store or copy >>>the information in any medium. Thank you. >>> >>>_______________________________________________ >>>gem5-dev mailing list >>>[email protected] >>>http://m5sim.org/mailman/listinfo/gem5-dev >>> >> >> >> -- IMPORTANT NOTICE: The contents of this email and any attachments are >>confidential and may also be privileged. If you are not the intended >>recipient, please notify the sender immediately and do not disclose the >>contents to any other person, use it for any purpose, or store or copy >>the information in any medium. Thank you. >> >> _______________________________________________ >> gem5-dev mailing list >> [email protected] >> http://m5sim.org/mailman/listinfo/gem5-dev >_______________________________________________ >gem5-dev mailing list >[email protected] >http://m5sim.org/mailman/listinfo/gem5-dev > -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
