Hi Nate, I'll just give it a 66 MHz clock (if that's reasonable), remove the if blocks and then bump the regressions accordingly.
The "goto" statements live on :-) Andreas On 25/11/2012 22:06, "nathan binkert" <[email protected]> wrote: >> It uses "goto". In my world that qualifies as broken :-) >What a confusing world you must live in! (That code is a perfect >example that 'Goto considered harmful' is considered harmful) > >> Kidding aside, I wouldn't know how to test it. If someone wants that >> functionality in the future I'd suggest they re-add it or resurrect it >> from the repo. > >Testing it would just be a matter of making sure that packets still >move even when you have a clock set on the ethernet device (one of the >two system test). That said, since nobody has used it in 7 years, it >doesn't have to stay. I'm not clear on what exactly you're trying to >accomplish, so I can't really comment on what I think the right thing >to do is. I leave it to you to decide. > > Nate >_______________________________________________ >gem5-dev mailing list >[email protected] >http://m5sim.org/mailman/listinfo/gem5-dev > -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
