----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1615/#review3797 -----------------------------------------------------------
Andreas, this patch works for me. I think we should not exit scons in any of the the cases related to protocol-buffers. If any thing that protocol-buffers requires is not available, we should print a warning, and proceed ahead with the rest of the compilation. - Nilay Vaish On Jan. 8, 2013, 6:47 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1615/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2013, 6:47 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9450:846d4e432427 > --------------------------- > scons: Allow pkg-config to fail and continue > > This patch changes the use of pkg-config such that protobuf is > disabled if the call to pkg-config is not successful. > > > Diffs > ----- > > SConstruct 56610ab73040 > > Diff: http://reviews.gem5.org/r/1615/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
