Hey guys, I'm running into the same build issues that Nilay is (both with and without this patch), and I'm on my machine with a default install of Ubuntu 12.04. I have root access, so I could verify that apt-get libprotobuf-dev fixes these errors, but I will eventually be migrating to the UW machines, where Nilay is already having trouble and we don't have root access. As such, I'd prefer to get this patch fixed up ASAP so we can update our internal repos.
The build error (below) that Nilay and I are running into seems to be incorrect functionality: Scons fails to find protobuf, and instead of building without it, it errors and quits the build process. I'm not very familiar with modifying requirements for the build system, so I'm having trouble finding why this is erroring like this. Can someone give me (us) pointers? Thanks, Joel On Thu, Jan 10, 2013 at 2:01 AM, Andreas Hansson <[email protected]>wrote: > > > > On Jan. 9, 2013, 3:37 p.m., Nilay Vaish wrote: > > > Some thing is wrong with this new version. Here is what I got -- > > > > > > scons: Reading SConscript files ... > > > Package protobuf was not found in the pkg-config search path. > > > Perhaps you should add the directory containing `protobuf.pc' > > > to the PKG_CONFIG_PATH environment variable > > > No package 'protobuf' found > > > Warning: pkg-config could not get protobuf flags. > > > Checking for leading underscore in global variables...(cached) no > > > Checking for C header file Python.h... (cached) yes > > > Checking for C library pthread... (cached) yes > > > Checking for C library dl... (cached) yes > > > Checking for C library util... (cached) yes > > > Checking for C library m... (cached) yes > > > Checking for C library python2.6... (cached) yes > > > Checking for accept(0,0,0) in C++ library None... (cached) yes > > > Checking for zlibVersion() in C++ library z... (cached) yes > > > Checking for GOOGLE_PROTOBUF_VERIFY_VERSION in C++ library protobuf... > no > > > Error: did not find protocol buffer library and/or headers. > > > Please install libprotobuf-dev and try again. > > This is intentional I suppose, as it finds protoc, but fails to then build > a binary that links to libprotobuf. > > Could you check why the build failed? I would say this is the desired > behaviour. > > > - Andreas > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1615/#review3809 > ----------------------------------------------------------- > > > On Jan. 9, 2013, 9:18 a.m., Andreas Hansson wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://reviews.gem5.org/r/1615/ > > ----------------------------------------------------------- > > > > (Updated Jan. 9, 2013, 9:18 a.m.) > > > > > > Review request for Default. > > > > > > Description > > ------- > > > > Changeset 9460:45525a59768b > > --------------------------- > > scons: Allow pkg-config to fail and continue > > > > This patch changes the use of pkg-config such that protobuf is > > disabled if the call to pkg-config is not successful. > > > > > > Diffs > > ----- > > > > SConstruct 8ca90cef0183 > > > > Diff: http://reviews.gem5.org/r/1615/diff/ > > > > > > Testing > > ------- > > > > > > Thanks, > > > > Andreas Hansson > > > > > > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev > -- Joel Hestness PhD Student, Computer Architecture Dept. of Computer Science, University of Wisconsin - Madison http://www.cs.utexas.edu/~hestness _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
