I guess. I don't really think I have much of a veto right anymore. That said, I don't think what I'm asking for is really a big deal. I'm mostly just asking to see the stuff that you've already written turned into a set of functions. Mostly just the big session.query statements and the big if then else block.
On Fri, Jan 25, 2013 at 9:17 AM, Andreas Hansson <[email protected]>wrote: > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1639/ > > On January 25th, 2013, 9:16 a.m., *Nathan Binkert* wrote: > > It seems to me that the majority of the code in this script should be > abstracted into classes/functions which are then used by the script, but > could also be used by others. I'm not asking for added functionality, just a > separation so that it can be used without copy/paste. > > Sounds sensible. Would it be an option to get this out first and then > generalise as we go forward? > > > - Andreas > > On January 15th, 2013, 10:29 a.m., Andreas Hansson wrote: > Review request for Default. > By Andreas Hansson. > > *Updated Jan. 15, 2013, 10:29 a.m.* > Description > > Changeset 9492:35ce7e2339f3 > --------------------------- > stats: Add example script to extract stats from SQL database > > This patch adds a simple python stript which is able to extract data from the > database based on the name of the stat. It is able to either print the result > to the screen, or write it to an output CSV file. It extracts the data for a > single dump. > > This script is designed as a rough reference for the creation of more > sophisticated stats manipulation scripts, and is therefore not feature rich. > > Diffs > > - util/stats/extractSQLStats.py (PRE-CREATION) > > View Diff <http://reviews.gem5.org/r/1639/diff/> > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
