----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1669/#review3961 -----------------------------------------------------------
src/base/types.hh <http://reviews.gem5.org/r/1669/#comment3825> I'm not a big fan of the - operator. Is it really needed? If it is used in many places, can we at least add an assert(c >= b.c)? src/base/types.hh <http://reviews.gem5.org/r/1669/#comment3826> I don't really like the idea of the shift operators for a Cycle count. It feels really unintuitive to me. Why are these needed? - Andreas Hansson On Jan. 26, 2013, 7:56 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1669/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2013, 7:56 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9486:ed62e6fcdb21 > --------------------------- > base: add some mathematical operators to Cycles class > > > Diffs > ----- > > src/base/types.hh b0fa6b872f40 > > Diff: http://reviews.gem5.org/r/1669/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
