> On Feb. 1, 2013, 2:20 a.m., Andreas Hansson wrote: > > src/base/types.hh, line 122 > > <http://reviews.gem5.org/r/1669/diff/1/?file=33575#file33575line122> > > > > I don't really like the idea of the shift operators for a Cycle count. > > It feels really unintuitive to me. > > > > Why are these needed? > > Nilay Vaish wrote: > Because ruby uses the << operator in one of its coherency protocol.
If we really need to shift things, I would still prefer to do it by going to a uint, do the shift, and then back to Cycles(res). Sounds reasonable? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1669/#review3961 ----------------------------------------------------------- On Feb. 1, 2013, 4:44 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1669/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 4:44 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9496:96c5401984f8 > --------------------------- > base: add some mathematical operators to Cycles class > > > Diffs > ----- > > src/base/types.hh 890fc69ba53c > > Diff: http://reviews.gem5.org/r/1669/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
