----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1767/#review4113 -----------------------------------------------------------
It seems to me that the CpuPort is not serving any purpose at all. Why can the ports derieved from the CpuPort, not be derieved from the MasterPort directly? - Nilay Vaish On March 14, 2013, 7:24 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1767/ > ----------------------------------------------------------- > > (Updated March 14, 2013, 7:24 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9585:c89ec115b2d0 > --------------------------- > cpu: Use the base MasterPort in the CPU port accessors > > This patch changes the port accessors in the CPU classes to use > MasterPort instead of the derived CpuPort. This simplifies creating > derivative CPUs that do not use the CpuPort. > > > Diffs > ----- > > src/cpu/base.hh 1a21964b7227 > src/cpu/checker/cpu.hh 1a21964b7227 > src/cpu/checker/cpu.cc 1a21964b7227 > src/cpu/inorder/cpu.hh 1a21964b7227 > src/cpu/o3/cpu.hh 1a21964b7227 > src/cpu/simple/atomic.hh 1a21964b7227 > src/cpu/simple/timing.hh 1a21964b7227 > > Diff: http://reviews.gem5.org/r/1767/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
