----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1767/#review4138 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On March 15, 2013, 3:37 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1767/ > ----------------------------------------------------------- > > (Updated March 15, 2013, 3:37 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9586:e053f062246c > --------------------------- > cpu: Remove CpuPort and use MasterPort in the CPU classes > > This patch changes the port in the CPU classes to use MasterPort > instead of the derived CpuPort. The functions of the CpuPort are now > distributed across the relevant subclasses. The port accessor > functions (getInstPort and getDataPort) now return a MasterPort > instead of a CpuPort. This simplifies creating derivative CPUs that do > not use the CpuPort. > > > Diffs > ----- > > src/cpu/base.hh ef864175dcc0 > src/cpu/base.cc ef864175dcc0 > src/cpu/checker/cpu.hh ef864175dcc0 > src/cpu/checker/cpu.cc ef864175dcc0 > src/cpu/inorder/cpu.hh ef864175dcc0 > src/cpu/inorder/cpu.cc ef864175dcc0 > src/cpu/o3/cpu.hh ef864175dcc0 > src/cpu/simple/atomic.hh ef864175dcc0 > src/cpu/simple/timing.hh ef864175dcc0 > > Diff: http://reviews.gem5.org/r/1767/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
