What's the review board? Is the code change process documented?
On Mar 25, 2013, at 6:46 PM, Nilay Vaish wrote: > On Mon, 25 Mar 2013, Michael Levenhagen wrote: > >> Has it been determined that this change is correct? If yes is it going to be >> committed? >> >> Mike >> >> diff -r b6a47b43f4df src/arch/x86/process.cc >> --- a/src/arch/x86/process.cc Mon Mar 18 11:24:56 2013 +0100 >> +++ b/src/arch/x86/process.cc Mon Mar 25 09:46:20 2013 -0600 >> @@ -98,7 +98,7 @@ >> vsyscallPage.base = 0xffffffffff600000ULL; >> vsyscallPage.size = VMPageSize; >> vsyscallPage.vtimeOffset = 0x400; >> - vsyscallPage.vgettimeofdayOffset = 0x410; >> + vsyscallPage.vgettimeofdayOffset = 0x0; >> > > After digging through the kernel and the glibc code, I just convinced my self > that this change is correct. If some one wants to cross check, then he/she > can read the file sysdeps/unix/sysv/linux/x86_64/gettimeofday.c in the source > tree of glibc. > > I suggest that you submit a patch on the review board. > > > -- > Nilay > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
