----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1800/#review4191 -----------------------------------------------------------
Seems fine. - Nilay Vaish On March 28, 2013, 3:30 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1800/ > ----------------------------------------------------------- > > (Updated March 28, 2013, 3:30 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9625:fdd9932e6ca5 > --------------------------- > cpu: Make the generators usable outside the TrafficGen module > > This patch enables the use of the generator behaviours outside the > TrafficGen module. This is useful e.g. to allow packet replay modes > for other devices in the system without having to replace them with a > TrafficGen in the configuration files. > > This change also enables more specific behaviours to be composed as > specific modules, e.g. BaseBandModem can use a number of generators > and have application-specific parameters based around a specific set > of generators. > > > Diffs > ----- > > src/cpu/testers/traffic_gen/SConscript 89aa34e10625 > src/cpu/testers/traffic_gen/generators.hh PRE-CREATION > src/cpu/testers/traffic_gen/generators.cc PRE-CREATION > src/cpu/testers/traffic_gen/traffic_gen.hh 89aa34e10625 > src/cpu/testers/traffic_gen/traffic_gen.cc 89aa34e10625 > > Diff: http://reviews.gem5.org/r/1800/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
