> On April 17, 2013, 3:21 p.m., Andreas Hansson wrote: > > tests/configs/base_config.py, line 129 > > <http://reviews.gem5.org/r/1824/diff/1/?file=35115#file35115line129> > > > > Why has this disappeared? > > Nilay Vaish wrote: > The call to init_cpu(), as of now, only creates the interrupt controller > for the cpu. When we switch from one cpu with another, we hand over the > interrupt controller as well. So, as such that call was not required. > Additionally, the interrupt controller in x86 architecture is a Pio > Device. > The init() function of the Pio Device class checks whether or not it is > connected to something. For a cpu that is not initially operational, > the interrupt controller is not connected to anything. This resulted > in a panic(). Hence, I removed that call.
Ok. Thanks for the clarification. I'd be keen to know if Andreas S has any input on this one. Is it needed for the KVM cpu or similar? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1824/#review4244 ----------------------------------------------------------- On April 17, 2013, 4:05 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1824/ > ----------------------------------------------------------- > > (Updated April 17, 2013, 4:05 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9639:c3aca6199d6a > --------------------------- > x86: regressions: add switcher full test > > > Diffs > ----- > > tests/SConscript 531a176f863d > tests/configs/base_config.py 531a176f863d > tests/configs/pc-switcheroo-full.py PRE-CREATION > tests/configs/x86_generic.py 531a176f863d > > Diff: http://reviews.gem5.org/r/1824/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
