----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1824/#review4270 -----------------------------------------------------------
Ship it! LGTM. I think I would have preferred to have the connectAllPorts call in init_system, but the current version is OK. - Andreas Sandberg On April 18, 2013, 9:48 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1824/ > ----------------------------------------------------------- > > (Updated April 18, 2013, 9:48 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9643:01ac53525db4 > --------------------------- > x86: regressions: add switcher full test > > > Diffs > ----- > > tests/SConscript 112382ddf96d > tests/configs/base_config.py 112382ddf96d > tests/configs/pc-switcheroo-full.py PRE-CREATION > tests/configs/x86_generic.py 112382ddf96d > > Diff: http://reviews.gem5.org/r/1824/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
