-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1826/
-----------------------------------------------------------

(Updated May 30, 2013, 4:45 p.m.)


Review request for Default.


Description
-------

Changeset 9639:2aae67c49743
---------------------------
mem: add retry mechanism for cache fills in classic cache model
The changeset 6122d201ff80 modeled the cache bank and blocks the cache access
if the target bank is busy.  However, due to the lack of retry mechanism at the
cache master port, that changeset cannot properly blocks the cache traffic that
is towards CPU.
This patch modifies the CoherentBus model and adds a flow control scheme to the
RespLayer.  With this modification, cache fill operations can now be properly
modeled.
@todo The modification to CoherentBus is a little hacky. e.g. The recvRetry
functions for Req and Resp are not symmetric
@todo Might also need to modify noncoherent bus
@todo There is no write buffer entries for cache fill operations. An
      incremental patch will be needed to model the cache fill buffer


Diffs (updated)
-----

  src/mem/cache/base.hh e2fafd224f43 
  src/mem/cache/cache_impl.hh e2fafd224f43 
  src/mem/coherent_bus.hh e2fafd224f43 
  src/mem/coherent_bus.cc e2fafd224f43 

Diff: http://reviews.gem5.org/r/1826/diff/


Testing
-------


Thanks,

Xiangyu Dong

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to