----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1885/#review4365 -----------------------------------------------------------
Ship it! I guess I spoke too soon in the other patch. - Nilay Vaish On May 27, 2013, 11:36 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1885/ > ----------------------------------------------------------- > > (Updated May 27, 2013, 11:36 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9741:32c0e8ed4c8a > --------------------------- > sim: Pre-compute the clock period > > This patch changes the source and derived clock domain such that no > virtual functions or multiplications are needed when calling > clockPeriod. Instead, the clock period is pre-computed when any > changes occur. For this to be possible, a clock domain must be aware > of its children and the corresponding data structures and methods have > been added to facilitate this. > > > Diffs > ----- > > src/sim/clock_domain.hh PRE-CREATION > src/sim/clock_domain.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/1885/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
