> On June 16, 2013, 5:06 a.m., Nathan Binkert wrote: > > Out of curiosity, was this any faster, or did you really just do it because > > I thought it was crazy. While I feel better about the code working this > > way, you indicated that there wasn't much of a performance impact. I hope > > you didn't do this because I objected. I really do feel that a performance > > measurement is worth more than gut reaction. (Perhaps you didn't do your > > performance test using something that stressed the clock and didn't want > > to?)
I ran the regressions multiple time and it did have an impact in the end. After compensating for fluctuations, it was probably in the order of ~5% of the regressions time, so closer to ~10% for the clock intensive runs. In short, your gut feeling was pretty spot on :-) - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1885/#review4438 ----------------------------------------------------------- On June 6, 2013, 2:37 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1885/ > ----------------------------------------------------------- > > (Updated June 6, 2013, 2:37 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9761:a04648a0d2c6 > --------------------------- > sim: Pre-compute the clock period > > This patch changes the source and derived clock domain such that no > virtual functions or multiplications are needed when calling > clockPeriod. Instead, the clock period is pre-computed when any > changes occur. For this to be possible, a clock domain must be aware > of its children and the corresponding data structures and methods have > been added to facilitate this. > > > Diffs > ----- > > src/sim/clock_domain.hh PRE-CREATION > src/sim/clock_domain.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/1885/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
