----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1887/#review4377 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On June 3, 2013, 3:40 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1887/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 3:40 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9738:160272d942df > --------------------------- > kvm: Don't handle IO and execute in the same tick > > We currently execute instructions in the guest and then handle any IO > request right after we break out of the virtualized environment. This > has the effect of executing IO requests in the exact same tick as the > first instruction in the sequence that was just run. There seem to be > cases where this simplification upsets some timing-sensitive devices. > > This changeset splits execute and IO (and other services) across > multiple ticks. This is implemented by adding a separate > RunningService state to the CPU state machine. When a VM requires > service, it enters into this state and pending IO is then serviced in > the future instead of immediately. The delay between getting the > request and servicing it depends on the number of cycles executed in > the guest, which allows other components to catch up with the CPU. > > > Diffs > ----- > > src/cpu/kvm/arm_cpu.hh 16f9d1fd37da > src/cpu/kvm/arm_cpu.cc 16f9d1fd37da > src/cpu/kvm/base.hh 16f9d1fd37da > src/cpu/kvm/base.cc 16f9d1fd37da > > Diff: http://reviews.gem5.org/r/1887/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
