----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1865/#review4518 -----------------------------------------------------------
src/cpu/pred/global.hh <http://reviews.gem5.org/r/1865/#comment4235> Is this right? src/cpu/pred/global.hh <http://reviews.gem5.org/r/1865/#comment4246> Pardon me for asking something that perhaps is very obvious, but why do we use a void* and not something more...useful? src/cpu/pred/global.cc <http://reviews.gem5.org/r/1865/#comment4236> Same as above src/cpu/pred/global.cc <http://reviews.gem5.org/r/1865/#comment4237> base/intmath has log2 if that helps... src/cpu/pred/global.cc <http://reviews.gem5.org/r/1865/#comment4238> Why not just globalCtrs(globalPredictorSize) in the initialization list? src/cpu/pred/global.cc <http://reviews.gem5.org/r/1865/#comment4239> Whitespace src/cpu/pred/global.cc <http://reviews.gem5.org/r/1865/#comment4240> Whitespace src/cpu/pred/global.cc <http://reviews.gem5.org/r/1865/#comment4241> A comment here elaborating on when/where this is deleted would be fantastic src/cpu/pred/global.cc <http://reviews.gem5.org/r/1865/#comment4242> Same as above. A comment on when/where it's deleted would be great src/cpu/pred/global.cc <http://reviews.gem5.org/r/1865/#comment4243> if _space_ ( Also whitespace at end of line src/cpu/pred/global.cc <http://reviews.gem5.org/r/1865/#comment4244> NULL please :-) src/cpu/pred/global.cc <http://reviews.gem5.org/r/1865/#comment4245> Whitespace Thanks a million for the changes. It would be great if the last little bit of formatting can be fixed up, and then I'd say it's all ready to go. - Andreas Hansson On July 15, 2013, 6:34 p.m., Taylor Lloyd wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1865/ > ----------------------------------------------------------- > > (Updated July 15, 2013, 6:34 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch adds a global-global (gAG) branch predictor, used by specifying > the "global" predType. > From BranchPredictor, it uses the following variables for configuration: > - globalPredictorSize > - globalCtrBits > - globalHistoryBits > > As such, it may conflict with the ongoing effort to factor out the redundant > variable in the predictors. > > > Diffs > ----- > > src/cpu/pred/BranchPredictor.py 13ffc0066b76 > src/cpu/pred/SConscript 13ffc0066b76 > src/cpu/pred/bpred_unit.cc 13ffc0066b76 > src/cpu/pred/global.hh PRE-CREATION > src/cpu/pred/global.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/1865/diff/ > > > Testing > ------- > > Prior to submission, this was tested by building build/ARM/gem5.debug, and > run against a subset of the SPEC CPU2006 benchmarks. Statistics generated > seem valid, and it caused no execution errors. > > > Thanks, > > Taylor Lloyd > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
